feat: merge mowali branch #286

shashi165 · 2021-09-28T02:54:29Z

Summary of changes

Now users can provide additional non-standard headers via rules.json. This will enable users to provide additional headers while redirecting the quote request
updated the documentation
some refactoring of code

…ed rules engine tests. Added Jest config. Added example rules.json.

… payer and payee

… for rules engine. Stubbed validateQuoteRequest method in relevant tests. Running rules engine in validateQuoteRequest (but not doing anything with the results yet).

…ig. Removed Istanbul config.

…nfig to call junit script. Added test results directory to gitignore.

…al payer and payee facts

…d rule execution and event handling. Removed empty quote validation, replaced with rules engine execution. Removed redundant setImmediate. New test for INVALID_QUOTE_REQUEST event. Expanded INVALID_QUOTE_REQUEST unit tests.

…nd updated the `quotes.tests.js` accordingly.

…x-unit-tests Unit tests fixes

…f originals

Updated unit tests in order to pass according to latest code changes.

Clean & update

Feature/cleanup code

Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>

…p/quoting-service into feat/merge-mowali-branch

mdebarros · 2021-10-29T15:36:47Z

I'm concerned there are no integration tests for this new functionality. Can you please write an integration test that shows the new rules all working together?

@shashi165 any response to my earlier request?

Hey @lewisdaly , there are no Integration Tests for this service, i.e. --> https://github.com/mojaloop/quoting-service/tree/master/test

The best we can do at this stage is to add a backlog item.

mdebarros

+1

lewisdaly · 2021-11-01T01:30:03Z

I'm concerned there are no integration tests for this new functionality. Can you please write an integration test that shows the new rules all working together?

@shashi165 any response to my earlier request?

Hey @lewisdaly , there are no Integration Tests for this service, i.e. --> https://github.com/mojaloop/quoting-service/tree/master/test

The best we can do at this stage is to add a backlog item.

That's troubling. @shashi165 can you please open a backlog item to add integration tests to this service as a part of this task?

shashi165 · 2021-11-02T12:47:20Z

I'm concerned there are no integration tests for this new functionality. Can you please write an integration test that shows the new rules all working together?

@shashi165 any response to my earlier request?

Hey @lewisdaly , there are no Integration Tests for this service, i.e. --> https://github.com/mojaloop/quoting-service/tree/master/test
The best we can do at this stage is to add a backlog item.

That's troubling. @shashi165 can you please open a backlog item to add integration tests to this service as a part of this task?

Hi @lewisdaly - created a story here: mojaloop/project#2570

comments addressed - axios version updated, follow-up story for integration tests created

mdebarros

Hey @shashi165,

I don't see any issues with the PR. But perhaps we should build a snapshot release and test it against the GP TTK tests before doing a final merge.

Let me know your thoughts on that. I would be happy to schedule a 1 hour call to do so....

Also see my one issue that you will need to address around changing the package version as it is already handled by our automated CI-CD releases.

package.json

mdebarros · 2022-02-09T14:33:56Z

Hey @shashi165,

I don't see any issues with the PR. But perhaps we should build a snapshot release and test it against the GP TTK tests before doing a final merge.

Let me know your thoughts on that. I would be happy to schedule a 1 hour call to do so....

Also see my one issue that you will need to address around changing the package version as it is already handled by our automated CI-CD releases.

GP Report

--------------------FINAL REPORT--------------------
Test Suite:GP Tests
Environment:moja2.test.mojaloop.live
┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 2318                          │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 2311                          │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 7                             │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 551                           │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 120                           │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 99.70%                        │
├───────────────────┼───────────────────────────────┤
│ Started time      │ Wed, 09 Feb 2022 14:28:10 GMT │
├───────────────────┼───────────────────────────────┤
│ Completed time    │ Wed, 09 Feb 2022 14:30:54 GMT │
├───────────────────┼───────────────────────────────┤
│ Runtime duration  │ 164301 ms                     │
└───────────────────┴───────────────────────────────┘

Bulk Report

--------------------FINAL REPORT--------------------
Test Suite:Bulk Tests
Environment:moja2.test.mojaloop.live
┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 134                           │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 25                            │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 109                           │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 14                            │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 3                             │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 18.66%                        │
├───────────────────┼───────────────────────────────┤
│ Started time      │ Wed, 09 Feb 2022 14:31:07 GMT │
├───────────────────┼───────────────────────────────┤
│ Completed time    │ Wed, 09 Feb 2022 14:31:49 GMT │
├───────────────────┼───────────────────────────────┤
│ Runtime duration  │ 42433 ms                      │
└───────────────────┴───────────────────────────────┘

shashi165 · 2022-02-09T20:51:14Z

test results of GP

mdebarros · 2022-02-11T08:11:17Z

+1

Test Suite:GP Tests
Environment:Development
┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 2318                          │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 2318                          │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 0                             │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 551                           │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 120                           │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 100.00%                       │
├───────────────────┼───────────────────────────────┤
│ Started time      │ Thu, 10 Feb 2022 18:44:35 GMT │
├───────────────────┼───────────────────────────────┤
│ Completed time    │ Thu, 10 Feb 2022 18:47:06 GMT │
├───────────────────┼───────────────────────────────┤
│ Runtime duration  │ 151522 ms                     │
└───────────────────┴───────────────────────────────┘
TTK-Assertion-Report-multi-2022-02-10T18:47:06.854Z.html was generated

Test Suite:Bulk Tests
Environment:Development
┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 134                           │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 134                           │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 0                             │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 14                            │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 3                             │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 100.00%                       │
├───────────────────┼───────────────────────────────┤
│ Started time      │ Thu, 10 Feb 2022 18:47:22 GMT │
├───────────────────┼───────────────────────────────┤
│ Completed time    │ Thu, 10 Feb 2022 18:47:25 GMT │
├───────────────────┼───────────────────────────────┤
│ Runtime duration  │ 3169 ms                       │
└───────────────────┴───────────────────────────────┘
TTK-Assertion-Report-multi-2022-02-10T18:47:25.595Z.html was generated

Thanks @shashi165 !

partiallyordered and others added 30 commits September 23, 2019 18:35

Tests converted to Jest

53f1b03

Added rules engine jsonpath dynamic fact

26cc810

Updated rules engine API. Added jsonpath package to dependencies. Add…

ee5f780

…ed rules engine tests. Added Jest config. Added example rules.json.

Updated hapi/subtext to patch vulnerability

7cbbe92

Updated example rules and corresponding tests to reflect real form of…

c0ce090

… payer and payee

Added switch endpoint to config to obtain payer and payee information…

ae4a017

… for rules engine. Stubbed validateQuoteRequest method in relevant tests. Running rules engine in validateQuoteRequest (but not doing anything with the results yet).

Tests converted to Jest

52e7f2f

Replaced coverage-check script. Added coverage threshold to jest conf…

c51c04d

…ig. Removed Istanbul config.

Uninstalled and reinstalled jest to fix vulnerability

b3ed58b

Added junit + config. Added test:junit npm script. Modified circle co…

dc1e922

…nfig to call junit script. Added test results directory to gitignore.

Merge remote-tracking branch 'msk-/test-with-jest'

a2027f3

Modified example rules and corresponding tests to better reflect actu…

7d006cd

…al payer and payee facts

Merge remote-tracking branch 'origin/master'

293fbf4

Merged upstream into fork

271e28f

Merge conflicts resolved

4b4acff

Manual merge from upstream

d830523

Integrated properly the new model/rules.js into model/quotes.js a…

9ddfa59

…nd updated the `quotes.tests.js` accordingly.

Simplified block of code that was unnecessarily using map.

5cc9bba

Merge pull request #1 from vbarzokas/bugfix/integrate-rules-engine-fi…

1dc5496

…x-unit-tests Unit tests fixes

Forwarding event-handler-modified quote request and headers instead o…

9f8df68

…f originals

Fixed tests by poorly mocking handleRuleEvents on the quotes model

bc17ba5

Cleaned a little bit the result of handleRuleEvents;

c967661

Updated unit tests in order to pass according to latest code changes.

Merge pull request #2 from vbarzokas/bugfix/update-unit-tests

75b879f

Clean & update

Deduplicated the functionality of request sending

5bcb954

Removed setImmediate from all places that it was used.

6e82010

Use CreateInternalServerFSPIOPError instead of CreateFSPIOPError

b0444a5

Merge pull request #3 from vbarzokas/feature/cleanup-code

87ec59c

Feature/cleanup code

mowdev-3411

3b04304

added more rules

b36efd3

shashi165 and others added 6 commits October 20, 2021 11:16

Update src/model/quotes.js

d94cb7d

Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>

Update src/model/quotes.js

89ed573

Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>

Update src/model/quotes.js

0cbc8ff

Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>

fixed audit issue

84e4722

Merge branch 'feat/merge-mowali-branch' of https://github.com/mojaloo…

8ebc2e7

…p/quoting-service into feat/merge-mowali-branch

fixed audit issue

2e237e0

shashi165 requested review from mdebarros and elnyry-sam-k and removed request for bushjames October 29, 2021 14:34

mdebarros previously approved these changes Oct 29, 2021

View reviewed changes

shashi165 added 2 commits February 7, 2022 16:48

bring in latest mowali version

014dd95

fixed tests

690fedd

shashi165 dismissed mdebarros’s stale review via 690fedd February 8, 2022 00:31

audit resolve

261f36f

shashi165 requested a review from mdebarros February 8, 2022 14:44

mdebarros requested changes Feb 8, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

revert package version

7824f6e

shashi165 added 2 commits February 9, 2022 11:39

removed the implementation specific payer/payee validation

77d9882

removed the implementation specific payer/payee validation

c15c30b

shashi165 requested a review from mdebarros February 9, 2022 20:20

removed comments

efb4075

mdebarros approved these changes Feb 11, 2022

View reviewed changes

shashi165 merged commit f92299b into master Feb 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: merge mowali branch #286

feat: merge mowali branch #286

shashi165 commented Sep 28, 2021 •

edited

Loading

mdebarros commented Oct 29, 2021

mdebarros left a comment

lewisdaly commented Nov 1, 2021

shashi165 commented Nov 2, 2021

mdebarros left a comment

mdebarros commented Feb 9, 2022

shashi165 commented Feb 9, 2022

mdebarros commented Feb 11, 2022 •

edited

Loading

feat: merge mowali branch #286

feat: merge mowali branch #286

Conversation

shashi165 commented Sep 28, 2021 • edited Loading

mdebarros commented Oct 29, 2021

mdebarros left a comment

Choose a reason for hiding this comment

lewisdaly commented Nov 1, 2021

shashi165 commented Nov 2, 2021

mdebarros left a comment

Choose a reason for hiding this comment

mdebarros commented Feb 9, 2022

shashi165 commented Feb 9, 2022

mdebarros commented Feb 11, 2022 • edited Loading

shashi165 commented Sep 28, 2021 •

edited

Loading

mdebarros commented Feb 11, 2022 •

edited

Loading