Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to any administration portals which call this (Settlements) API #926

Closed
11 tasks done
elnyry-sam-k opened this issue Aug 12, 2019 · 0 comments
Closed
11 tasks done
Assignees
Labels
Milestone

Comments

@elnyry-sam-k
Copy link
Member

elnyry-sam-k commented Aug 12, 2019

Goal:

As a I want to so that

getSettlementWindowsByParams [Story #5]

The parameters for the getSettlementWindowsByParams resource in the API described in Ref_2 above should be extended to allow a caller to request settlement windows by currency ID. The same constraints on the currency code as described in Section 6.1.1.2 above should be used.

NOTE: this change will also require changes to any administration portals which call this API – In release notes [Story #6]

Tasks:

  • Modify Swagger def
  • Modify DAO script
  • Modify handler script
  • Add unit tests to cover delivered functionality
  • Address PR comments

Acceptance Criteria:

  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.

Pull Requests:

Follow-up:

  • N/A

Dependencies:

Accountability:

@lazolalucas lazolalucas self-assigned this Feb 14, 2020
@ggrg ggrg added this to the Sprint 9.2 milestone Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants