ML OSS Account Lookup Service (ALS) Implementation -Testing

[elnyry-sam-k]

Goal:

As a DFSP
I would like to have an implementation that is fully tested that meets the minimum requirements for code coverage. I would also want integration tests to fully test the ALS integration with Oracles and central-ledger.

Tasks:

• Refactor the ALS code-base according to the design
  • Unit tests
    • Oracle
    • Parties
    • participant
  • Code Coverage
  • Integration tests
• Update all dependencies
• Fix knex pooling issue (@rmothilal may have more info on this)
  - [ ] Update the helm charts for updated default.json config:
  - [ ] DISPLAY_ROUTES
  - [ ] DB_CONNECTION_POOL_MIN and DB_CONNECTION_POOL_MAX
  Helm config will be covered as a part of Refactor central-services-database to use config instead of connection string #1008 helm changes

Acceptance Criteria:

• Unit tests [Now using JEST testing framework]
• Code coverage [Coverage is by the built in coverage tool in JEST i.e. nyc]
• Integration tests

Notes:
Please check code in quoting service to validate how to configure JEST in the package.json

Pull Requests:

• Feature/656 als unit tests account-lookup-service#81 - Updating dependencies and fixing tests
• feature/add-unit-tests account-lookup-service#93 - Major refactor of tests and coverage
• Feature/656 add integration tests account-lookup-service#100 - Integration tests
• TBD

Follow-up:

• TBD

Dependencies:

Accountability:

• Owner: @rmothilal
• QA/Review: @rmothilal @mdebarros

[lewisdaly]

I'm currently waiting for review on the major unit test PR before adding the integration test config.