Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for central-settlement - 2 #635

Closed
21 tasks done
elnyry-sam-k opened this issue Feb 15, 2019 · 0 comments
Closed
21 tasks done

Integration tests for central-settlement - 2 #635

elnyry-sam-k opened this issue Feb 15, 2019 · 0 comments
Assignees
Labels
Milestone

Comments

@elnyry-sam-k
Copy link
Member

elnyry-sam-k commented Feb 15, 2019

Goal:
As a Contributor
I would like to add integration tests for central-settlement
so that the settlement features testing can be automated

Tasks:

  • Use central-settlement/test/util/scripts/settlementTransfer scripts as a starting point for creation of integration tests [@ggrg]
  • Add integration tests following test/util/scripts/settlementTransfer demo scripts [@ggrg]
    • Populate initial admin data through central-ledger micro service and assert [@ggrg]
    • Populate transfer through ml-api-adapter, central-ledger, simulator and assert [@ggrg]
    • Close settlement window and assert valid [@ggrg]
    • Create settlement and assert [@ggrg]
    • PS_TRANSFERS_RECORDED for PAYER and assert [@ggrg]
    • PS_TRANSFERS_RECORDED for PAYEE and assert [@ggrg]
    • Settlement to PS_TRANSFERS_RESERVED and assert [@ggrg]
      • Resolve issue with open kafka producer handle [@ggrg]
    • Settlement to PS_TRANSFERS_COMMITTED and assert [@ggrg]
    • SETTLED for PAYER and assert [@ggrg]
    • SETTLED for PAYER - additional note and assert [@ggrg]
    • SETTLED for PAYEE / Settlement SETTLED and assert [@ggrg]
  • Add unit tests and provide full coverage for newly added code in /src directory [@ggrg]
  • Prepare integration-runner.sh script for central-settlement [@ggrg, @mdebarros, @rmothilal]
  • Enable running integration tests for central-settlement in circleCI (enable the path) [@ggrg, @mdebarros, @rmothilal]
  • Make sure integration tests pass/fail as expected in circleCI [@ggrg, @mdebarros, @rmothilal]

Acceptance Criteria:

  • Integration tests are provided for central-settlement and work in circleCI

PRs

Dependencies:

Accountability:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants