Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Settlements API failure #454

Closed
15 tasks done
rmothilal opened this issue Sep 14, 2018 · 0 comments
Closed
15 tasks done

Investigate Settlements API failure #454

rmothilal opened this issue Sep 14, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@rmothilal
Copy link

rmothilal commented Sep 14, 2018

Priority: High
Investigate why the central-settlements API crashed on Kubernetes.
you search should relook at getWindowsBySettlementIdAndParticipantId function in src/models/settlement/facade.js

Tasks:

  • Run local instance of the environment to be able to test based on @mdebarros 's video https://drive.google.com/file/d/1HHuszQ3bjSTbXKujf6h0JkmYBW2K0HKD/view [@vgenev]
  • Fix logging of errors [@vgenev]
  • Put logging throughout the settlements API [@vgenev]
  • Investigate the suggested method behavior [@vgenev]
  • Fix any unwanted behavior [@vgenev]
  • Fix unit tests of the the above fixes [@vgenev]
  • Make coverage 100% again [@vgenev]
  • Run postman tests for few hours without restarting [@vgenev]
  • transfer.prepare
  • transfer.fulfil
  • close settlementWindow
  • trigger settlement event
  • settle the accounts
  • all available for the Settlement API GETs
  • with delay slightly bigger than the enum cache
  • repeat

Acceptance criteria:

PRs:

Accountability:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants