Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX] Adjust participant account validations in quoting service to support FX #3933

Closed
19 of 20 tasks
vijayg10 opened this issue May 29, 2024 · 2 comments
Closed
19 of 20 tasks
Assignees
Labels
core-dev-squad fx Label for FX issues oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story

Comments

@vijayg10
Copy link

vijayg10 commented May 29, 2024

Goal:

As a mojaloop community member making use of FX

I want to validate the correct participants accounts

so that I am confident that those accounts are active and are in place before agreeing to the quote

Acceptance Criteria:

  • Refactored POST /quotes
    • If supportedCurrencies is set in the payer object, then we should validate the payer against all those currencies
    • If it is not set, then we should validate only payer payee against the currency in the quotes request. But we can't validate payee and it will be done in PUT /quotes.
  • Refactored PUT /quotes
    • If payeeReceiveAmount is set, validate payee against the payeeReceiveAmount currency
    • If not, validate payee against the transferAmount currency
  • This refactoring doesn't break the exiting GP tests
  • Add integration tests for this use case (POST /quotes and PUT /quotes)

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

  • Update participants accounts validation for POST /quotes requests [ Done ]
  • Update participants accounts validation for PUT /quotes requests [ Done ]
  • Write integration tests [ Done ]
  • Validate GP tests pass [Done]

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@vijayg10 vijayg10 added story oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it core-dev-squad fx Label for FX issues labels May 29, 2024
@PaulGregoryBaker
Copy link

1 pt left + bug needs fixing.

@vijayg10
Copy link
Author

vijayg10 commented Jun 27, 2024

I think one of the acceptance criteria is wrong in the story.
If it is not set, then we should validate only payer against the currency in the quotes request.

If there is no supportedCurrencies in the quotes request, that means that's normal quotes request or payer side conversion. In both cases we can validate if payee has an account in the currency specified in quotes request.

But we mentioned it as 'payer' in that point.
I updated it correctly and create a PR against fx branch. mojaloop/quoting-service#340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-dev-squad fx Label for FX issues oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story
Projects
None yet
Development

No branches or pull requests

3 participants