Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15] 4.18 Handle timeouts (In TransferHandler and PositionHandler) #320

Closed
11 of 20 tasks
shashi165 opened this issue Jun 21, 2018 · 1 comment
Closed
11 of 20 tasks
Assignees
Labels
Milestone

Comments

@shashi165
Copy link

shashi165 commented Jun 21, 2018

Goal:
As a Switch
I would like the implementation for handling Time-outs of transfers be done in TransferHandler and PositionHandler
so that the time-outs are handled in central-services

Tasks:

  • Test time-out handling in PositionHandler - [@shashi165]
    • make sure functionality works as expected - [@shashi165]
    • check if unit tests are there - [@shashi165]
    • check if integration tests are there
  • fix the bug in ML_API_ADAPTER where we check the status of the notification message before sending the callback, We should send the callback irrespective of the status. - [@shashi165] - PR Feature/#320 fix bug in notification handler ml-api-adapter#44
  • Implement Timeouts handling in TransferHandler
    • Unit tests
    • Integration tests
    • Code coverage
  • Implement Timeouts handling in PositionHandler
    • Unit tests
    • Integration tests
    • Code coverage
  • Test timeouts work end-to-end

Acceptance Criteria:

  • TransferHandler to consume time-out message and update transfer state (to Aborted or Expired - make sure this state aligns with design)
  • PositionHandler to consume time-out message and update Position of the Payer
  • Test time-out handling end-to-end

Dependencies:

Pull Requests

Accountability:

  • Owner
  • QA/Review
@elnyry-sam-k elnyry-sam-k changed the title 4.18 Transfer Handler Timeout - High 4.18 Handle timeouts (In TransferHandler and NotificationHandler) Jul 31, 2018
@elnyry-sam-k elnyry-sam-k changed the title 4.18 Handle timeouts (In TransferHandler and NotificationHandler) 4.18 Handle timeouts (In TransferHandler and PositionHandler) Aug 6, 2018
@elnyry-sam-k elnyry-sam-k added this to the Sprint 3.4 milestone Aug 7, 2018
@elnyry-sam-k
Copy link
Member

Moving this over to next Sprint as this Sprint is overloaded (at 150%) and doesn't look like we'll get to this and had additional work in deploying 3.3 codebase and fixing bugs related to that (Items #403 , #392

@elnyry-sam-k elnyry-sam-k changed the title 4.18 Handle timeouts (In TransferHandler and PositionHandler) [15] 4.18 Handle timeouts (In TransferHandler and PositionHandler) Aug 20, 2018
@shashi165 shashi165 self-assigned this Aug 27, 2018
@rmothilal rmothilal self-assigned this Aug 28, 2018
@ggrg ggrg closed this as completed Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants