Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further refine ingress subsequent to updating to networking/v1 #2987

Open
tdaly61 opened this issue Oct 12, 2022 · 2 comments
Open

further refine ingress subsequent to updating to networking/v1 #2987

tdaly61 opened this issue Oct 12, 2022 · 2 comments
Assignees
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it

Comments

@tdaly61
Copy link

tdaly61 commented Oct 12, 2022

Summary:
Issues #2352 updates the ingress supplied with Mojaloop helm charts to networking/v1 but is anticipated to initially leave several tasks concerning ingress undone. The remaining items concerning ingress are

  1. turn off all non-essential ingress in the values.yaml files
  2. identify which ingress can be tested today with the TTK and turn on and test this subset of supplied ingress
  3. identify and fix any issues from item-2 above
  4. add in a disclaimer to all non-tested ingress that they have not been tested and are for example use only
  5. examine a bit more closely item-4 above because it is not clear that all of the ingress we supply would be of use to anyone in any realistic or desirable deployment scenario AND if that is true elimination of these non-functional ingress and associated configuration reduces future code maintenance requirements and improves security. [

Note the supply of numerous external http paths to mojaloop components is on the basis that an external http(s) path is or could be required to that component from outside the kubernetes cluster that the component (service) is running in. With 40 supplied ingress it seems initially unlikely that these could ever all be required to access an interact with the far more modest published Mojaloop APIs catalog at https://docs.mojaloop.io/api/.

( seems like item-5 above would a good topic for further discussion at the DA. )

Severity:
high
Priority:
critical
Expected Behavior

Notes:

  • Severity when opened: high
  • Priority when opened: high
@tdaly61 tdaly61 added the bug Something isn't working or it has wrong behavior on a Mojaloop Core service label Oct 12, 2022
@tdaly61 tdaly61 self-assigned this Oct 12, 2022
@elnyry-sam-k elnyry-sam-k added the oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it label Oct 13, 2022
@mdebarros
Copy link
Member

@tdaly61 is this a bug, since this seems more like a feature?

@tdaly61
Copy link
Author

tdaly61 commented Oct 26, 2022

@mdebarros : well I think it depends on how we each view security and quality which I think is where we are diverging. That said I reckon over a beer or 2 we can narrow that gap :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Projects
None yet
Development

No branches or pull requests

3 participants