Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-Snippets to support generating backwards compatible OpenAPI Definitions #2706

Open
11 tasks
mdebarros opened this issue Mar 7, 2022 · 1 comment
Open
11 tasks
Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story to-be-refined This story is ready to be groomed

Comments

@mdebarros
Copy link
Member

mdebarros commented Mar 7, 2022

Goal:

As a Developer

I want to use API-Snippets to generate OpenAPI definitions for all supported versions of the Mojaloop FSPIOP specification

so that Mojaloop components can utilise the generated OpenAPI definitions for backward compatibility

Acceptance Criteria:

  • Documentation is made available on how to use api snippets of various published versions of the Mojaloop APIs (FSPIOP, 3PPI APIs, etc)
  • API Snippets for Mojaloop APIs' published versions are made available for consumption by Mojaloop services

Complexity: High

Uncertainty: Medium


Tasks:

  • TBD [ @? ]

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

  • TBD

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@mdebarros mdebarros added oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story to-be-refined This story is ready to be groomed labels Mar 7, 2022
@mdebarros mdebarros changed the title API-Snippets to support generating backward compatible OpenAPI Definitions API-Snippets to support generating backwards compatible OpenAPI Definitions Mar 7, 2022
@kleyow
Copy link

kleyow commented Mar 7, 2022

@mdebarros Might not fully understand the story since it's fresh but snippets already supports 1.0 and 1.1 of the fspiop api.

https://github.com/mojaloop/sdk-scheme-adapter/blob/master/src/InboundServer/api_template.yaml

You simple change the .../v1_1 to the version of your choice and then run a command to output a bundled version
"build:openapi:inbound": "openapi bundle --output ./InboundServer/api.yaml --ext yaml ./InboundServer/api_template.yaml"

openapi: 3.0.0
info:
  version: '1.1'
  title: Open API for FSP Interoperability (FSPIOP)
  description: >-
    Based on API Definition.docx updated on 2020-05-19 Version 1.1.
    API supports a maximum size of 65536 bytes (64 Kilobytes) in the HTTP
    header.
  license:
    name: Open API for FSP Interoperability (FSPIOP)
paths:
  '/participants/{ID}/error':
    $ref: '../node_modules/@mojaloop/api-snippets/fspiop/v1_1/openapi3/paths/participants_ID_error.yaml'
  '/participants/{ID}':
    $ref: '../node_modules/@mojaloop/api-snippets/fspiop/v1_1/openapi3/paths/participants_ID.yaml'
  '/participants/{Type}/{ID}/error':
    $ref: '../node_modules/@mojaloop/api-snippets/fspiop/v1_1/openapi3/paths/participants_Type_ID_error.yaml'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story to-be-refined This story is ready to be groomed
Projects
None yet
Development

No branches or pull requests

2 participants