Central-settlements calculating amounts incorrectly for every settlementModel that matches the ledgerAccountTypeId

[mdebarros]

Summary:
Central-settlements is calculating amounts incorrectly based on the Insert SQL statement: https://github.com/mojaloop/central-settlement/blob/master/src/models/settlementWindow/facade.js#L220.

It is calculating the amount incorrectly for every settlementModel that matches the ledgerAccountTypeId.

Severity:
High

Priority:
Critical

Expected Behavior

• settlementWindowContent table should contain:
  • An entry for cach settlementWindow matching a speccific currency
  • Each entry should also contain the associated settlementModel id matching the currency and ledgerAccountTypeId where settlementGranularityId = Enum.Settlements.SettlementGranularity.NET
• settlementContentAggregation table must reflect the above entry, providing an "amount" calculation for each participant+participantRole combination

Steps to Reproduce

1. Create more than one settlementModel for two different currencies
2. Send several transfers that match one of the above currencies
3. Close the associated settlementWindow, and monitor the settlementContentAggregation amounts being "double" counted

Specifications

• Component (if known): Central-Settlements
• Version: 12.x
• Platform: Node
• Subsystem:
• Type of testing: manual
• Bug found/raised by: @vgenev

Notes:

• Severity when opened: High
• Priority when opened: Critical