Quoting Service fails to send error callbacks

[oderayi]

Summary:
The quoting service is currently failing to forward error callbacks when the Payee FSP responds to a quote request with invalid response e.g specifying "Accept" header in a PUT callback.

Severity: Medium

Priority: Medium

Expected Behavior
When a quote request is sent to a Payee FSP, and the Payee FSP sends back an invalid response e.g. specifying "Accept" header in a PUT callback, the callback request should pass with a 200 but an error callback should be sent back to the Payee FSP noting the error in the earlier request.

Steps to Reproduce

1. Send a POST /quotes request to a Payee FSP (noresponsepayeefsp)
2. Send a PUT /quotes/{ID} back from noresponsepayeefsp to payerfsp
3. Note error log in quoting service and the fact that no error callback is received back at the Payee FSP end

Tasks

• 'Accept' header validation for PUT /quotes/{ID} should be moved to swagger or done synchronously in the handler using the plugin in central services shared library
• span issues need to be fixed by introducing childSpan at relevant places in the code base (e.g. when span instances are passed to models)
• models should handle errors (including callback) and not throw

Specifications

• Component (if known): Quoting Service
• Version: 11.1.1
• Platform:
• Subsystem: Quoting
• Type of testing: E2E
• Bug found/raised by: @oderayi