Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content-type header to use v1.1 #1615

Closed
32 of 36 tasks
elnyry-sam-k opened this issue Aug 20, 2020 · 0 comments
Closed
32 of 36 tasks

Update content-type header to use v1.1 #1615

elnyry-sam-k opened this issue Aug 20, 2020 · 0 comments
Assignees
Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story
Milestone

Comments

@elnyry-sam-k
Copy link
Member

elnyry-sam-k commented Aug 20, 2020

Goal:

As an FSP

I want to use headers to indicate and understand the version supported by a Switch

so that I can then understand compatibility and proceed further with messages

Acceptance Criteria:

  • Switch headers use version 1.1 for Content-Type, Accept as relevant for outgoing messages
  • Switch headers support both 1.1 and 1.0 for Content-Type, Accept as relevant for incoming messages
  • Postman tests verify support for v1.1, v1.0 messages and v1.1 version on Switch messages

Complexity: The header changes need to be made (from v1.0 to v1.1) and corresponding changes in tests

Uncertainty:

Notes:

  • v1.1 and v1.0 messages should be accepted by the Switch
  • Pass-through messages are not updated
  • Only messages originating in the Switch will always use v1.1
  • Currently identified: GET /parties which triggers GET /participants and then GET /parties; Error callbacks and PATCH notification
  • timeout handler has header version hardcoded to 1.0
  • PATCH returns whatever version has been sent by dfsp, the sdk-standard-components method has 1.0 hardcoded. when fixed to 1.1 it returns back 1.1.
  • what to do with simulators?

Tasks:

  • Update content-type, Accept headers to v1.1 as needed in core services for outgoing messages
    • sdk-standard-component
    • sdk-scheme-adapter
    • Decide on the way to pass the api version into central-services-shared methods (switchDefaultHeaders and sendRequest)
    • central-services-shared
    • ALS
    • quoting-service
    • central-ledger
    • transaction-requests (including authorizations)
  • Support content-type, Accept headers for both v1.1, v1.0 as needed in core services for incoming messages
    • ALS
    • quoting-service
    • central-ledger
    • transaction-requests (including authorizations)
  • Update MojaSim postman tests for the headers
    • create example tests
    • on support for v1.1, v1.0
    • and checks on messages coming out of the Switch (to have v1.1)

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story
Projects
None yet
Development

No branches or pull requests

3 participants