Switch not rejecting an invalid request received from DFSP during Transfer-Fulfillment stage

[Dorota-MB]

Summary:

Forex Transfer failing at MTN but getting successful on Switch.

When SWITCH receives the PUT/Transfers request from payee DSFSP with transferState=RESERVED instead of transferState=COMMITTED (during the transfer fulfilment stage), SWITCH is not rejecting it and instead its responding back with a PUT /Transfer response with FSPIOP-Source as "switch" due to which the transaction is getting failed on payee DFSP end. but however the transaction is getting Successful (COMMITTED) on the SWITCH end although it received error 503 response from payee DFSP.

Observed behaviour:

SWITCH is NOT rejecting the Invalid REQUEST received from payee DFSP's during the Transfer-Fulfilment stage. The transaction is NOT getting ABORTED instead its getting COMMITTED on the SWITCH end.

Expected behaviour:

The transaction shouldn’t get COMMITTED,

Switch should just reject the invalid request received from payee DFSP and the transaction should timeout eventually. which is “ABORTED” and then both sides should get notifications.

Severity: Low

Priority: High

Steps to Reproduce:

Trigger the Forex transfer between the Sims one connecting to Mowali v1.0 and the other to Mowali v1.1

Transfer stage logs from fxp_adapter, fxp server and INT WSO2 are attached.

This happening in the COMMIT stage. “Step 10 - Commit payee Transfer” in the below pic:

Freshservice issue linked to Jira:
#SR-31463 (https://modusbox.freshservice.com/helpdesk/tickets/31463) - Switch NOT rejecting an Invalid REQUEST received from DFSP's during Transfer-Fulfilment stage

Component:
Version: Mowali release 13.1 - for OSS component versions see here https://modusbox.atlassian.net/wiki/spaces/CV/pages/780763358/Mowali+Release+13.1

Platform: SBX

Bug found/raised by: @Siva Chunduru

Notes:
Int_wso2_fspiop_sorce_issue_logs.txt
fxp_adapter_fspiop_source_issue_logs.txt
fxp_server_fspiop_source_issue_logs.txt

Pull Requests

• #1547: Ignore "RESERVED" transferState from v1.0 clients on fulfill callback central-ledger#770
• #1547: Bump version to v11.1.2 central-ledger#771
• #1547: Fail transfer fulfill with "RESERVED" state and v1.0 content-type central-ledger#773
• #1547: Update dependencies (central-object-store etc.) central-ledger#774
• #1547: Add tests for transfer fulfill reserved postman#161
• #1547: Update central-ledger position and fulfill handlers to v11.1.4 helm#364

[oderayi]

Bug now fixed and released in Central Ledger v11.1.4

[elnyry-sam-k]

Thanks @oderayi , would be nice to have this verified on a deployment.. @amarmodus what do you think?

[amarmodus]

Thanks @oderayi , would be nice to have this verified on a deployment.. @amarmodus what do you think?

yes we should verify it @elnyry-sam-k

[oderayi]

Thanks @oderayi , would be nice to have this verified on a deployment.. @amarmodus what do you think?

Sure @elnyry-sam-k. I didn't realise you reopened it for deployment validation. I'll reopen with Review/QA status.

[amarmodus]

--To be discussed--