Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulator has invalid fulfilment created for transfers POST #1415

Closed
aenns opened this issue Jun 1, 2020 · 0 comments
Closed

Simulator has invalid fulfilment created for transfers POST #1415

aenns opened this issue Jun 1, 2020 · 0 comments
Assignees
@rmothilal
Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Milestone
Sprint 10.5

Comments

@aenns
Copy link

aenns commented Jun 1, 2020

Summary:
There is an issue with the way we create the fulfillment between the simulator and the way it is validated on central-ledger, integration tests are seeming to fail because of this for central-settlement.

There was a recent change to use the sdk-standard-components to get the fulfillment from the ilpPacket

Severity:
Low

Priority:
Medium

Expected Behavior
A valid fulfillment is created when a POST transfer is sent to the simulator

Steps to Reproduce

  1. run central-settlement integration tests with simulator image tag is 'latest'

Specifications

  • Component (if known): Legacy Simulator
  • Version: v10.3.0
  • Type of testing: Executing integration tests
  • Bug found/raised by: @aenns @rmothilal

Notes:
A workaround is to use v9.5.0 of the simulator

  • Severity when opened: Low
  • Priority when opened: Medium
@aenns aenns added the bug label Jun 1, 2020
@aenns aenns added this to the Sprint 10.4 milestone Jun 1, 2020
@amarmodus amarmodus mentioned this issue Jun 1, 2020
Closed
22 tasks
@elnyry-sam-k elnyry-sam-k removed this from the Sprint 10.4 milestone Jun 22, 2020
@rmothilal rmothilal changed the title Simulator has invalid fulfullment created for transfers POST Simulator has invalid fulfilment created for transfers POST Jul 1, 2020
@rmothilal rmothilal mentioned this issue Jul 1, 2020
Merged
@rmothilal rmothilal self-assigned this Jul 1, 2020
@elnyry-sam-k elnyry-sam-k added this to the Sprint 10.5 milestone Jul 2, 2020
@elnyry-sam-k elnyry-sam-k added the oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it label Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmothilal rmothilal

Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Projects
None yet
Milestone
Sprint 10.5
Development

No branches or pull requests
3 participants
@aenns @elnyry-sam-k @rmothilal