GET /quotes for unknown quote ID error response is 1001 instead of 3205

[amarmodus]

Summary:
GET /quotes for unknown quote ID error response is 1001 instead of 3205

Tasks:

• Bug Repro
• Fix simulator to send 3205 error callback async instead of 404 sync
• Fix quoting service to return generic 3000 error instead of 1001
• Validate the changes
• Fix tracing issues
• Release cs-shared 9.1.1
• Update QS with cs-shared 9.1.1
• Make sure test added to OSS API postman test collection (@amarmodus) - part of 971

Severity:
Low

Priority:
Low

Expected Behavior
202 response with error callback of 3205.

Steps to Reproduce
curl --location --request GET 'http://dev1-quoting-service.mojaloop.live/quotes/482f5ea4-67b6-431a-9737-c77b0123706c'
--header 'Accept: application/vnd.interoperability.quotes+json;version=1'
--header 'Content-Type: application/vnd.interoperability.quotes+json;version=1.0'
--header 'Date: Fri, 17 Jan 2020 10:37:29 GMT'
--header 'FSPIOP-Source: payerfsp'
--header 'FSPIOP-Destination: payeefsp'

make sure the quote id is valid UUID but unused quote ID.

Specifications

• Component (if known): central-services
• Version:v8.7.0
• Platform: AWS
• Subsystem:quoting service
• Type of testing: functional
• Bug found/raised by:@amarmodus

Notes:

• Severity when opened:
• Priority when opened:

Pull Requests

• Fix for #1173 - GET /quotes for unknown quote ID error response is 1001 instead of 3205 quoting-service#139
• Fix PUT response codes for quoting service documentation#166
• Part of fix for #1173 - GET /quotes for unknown quote ID error response is 1001 instead of 3205 simulator#138
• Fix possible 'span already finished' bug in plugin central-services-shared#177

[elnyry-sam-k]

@amarmodus I agree that it shouldn't be 1001 in this case. I would actually say its 3000 - Generic client error if the Switch gets a 404 synchronously from the FSP on the other side (in our case, a simulator).

How would the Switch know that the other FSP rejected it because it wasn’t found? If the simulator sends an error callback with 3205, we can just relay / forward it, otherwise, the Switch - in pass through mode has no visibility of it

So, two things, I think we should update the current simulator to give a 3205 in case an ID is not found and not a 404 and on secondly, if we get a 404 from the FSP on the other side, we can only send something generic like 3000 to the initiating FSP

What do you think..

@oderayi - please let us know if you have any further thoughts..

[amarmodus]

@amarmodus I agree that it shouldn't be 1001 in this case. I would actually say its 3000 - Generic client error if the Switch gets a 404 synchronously from the FSP on the other side (in our case, a simulator).

How would the Switch know that the other FSP rejected it because it wasn’t found? If the simulator sends an error callback with 3205, we can just relay / forward it, otherwise, the Switch - in pass through mode has no visibility of it

So, two things, I think we should update the current simulator to give a 3205 in case an ID is not found and not a 404 and on secondly, if we get a 404 from the FSP on the other side, we can only send something generic like 3000 to the initiating FSP

What do you think..

@oderayi - please let us know if you have any further thoughts..

@elnyry - Yes agreed, switch doesn't know the error number, if it is not provided by the simulator. Looks like switch is passing 1001 error code.

[amarmodus]