Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added ssl Support #494

Merged
merged 2 commits into from
Feb 25, 2022
Merged

feat: added ssl Support #494

merged 2 commits into from
Feb 25, 2022

Conversation

donaldbartlett
Copy link
Contributor

added SSL Support for KAFKA and Event Hub connections

@donaldbartlett
added SSL Support
48a62e4 
added SSL Support for KAFKA and Event Hub connections
@mdebarros mdebarros changed the title added SSL Support feat: added ssl Support Feb 25, 2022
mdebarros
mdebarros reviewed Feb 25, 2022
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @donaldbartlett for the contribution! It is muchly appreciated!

I have two comments for your attention.

P.S. I also renamed the PR to meet our community contributions guide/standard --> https://docs.mojaloop.io/legacy/contributors-guide/standards/creating-new-features.html#open-a-pull-request-pr

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@donaldbartlett
Updated per recommendation from Miguel
bb6fa9f 
moving cert injection to k8s runtime
@CLAassistant
Copy link

CLAassistant commented Feb 25, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@elnyry-sam-k
Copy link
Member

Thanks @donaldbartlett for the PR and @mdebarros for the comments..

In addition @donaldbartlett , can you please accept the CLA to take this forward?

@donaldbartlett
Copy link
Contributor Author

Thanks @donaldbartlett for the PR and @mdebarros for the comments..

In addition @donaldbartlett , can you please accept the CLA to take this forward?

Hi Sam, signed CSA so should be good to go.

Will review links provided before doing the next few PR's

mdebarros
mdebarros approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Please merge.

@mdebarros mdebarros merged commit 86cf167 into mojaloop:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebarros mdebarros mdebarros approved these changes

@vgenev vgenev Awaiting requested review from vgenev

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

@lewisdaly lewisdaly Awaiting requested review from lewisdaly

@oderayi oderayi Awaiting requested review from oderayi

@shashi165 shashi165 Awaiting requested review from shashi165

@vijayg10 vijayg10 Awaiting requested review from vijayg10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donaldbartlett @CLAassistant @elnyry-sam-k @mdebarros