Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#2092): upgrade nodeJS version for core services #49

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Jul 12, 2022

feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092

  • Standardised CI scripts
  • Updated docker-compose files to work correctly
  • Fixed lint issues
  • Updated .nvmrc to latest LTS version
  • Added standard CI scripts/config to package.json: release, snapshot, standard-version, etc
  • Updated gitignore to include test/results and IGNORE patterns
  • Updated README with standard auto-release information
  • Fixed imports
  • Fixed lint issues
  • Cleaned up Package.json
  • Updated dockerfile
  • Updated Ava and fixed Sinon mock issues
  • Fixed package test scripts to ensure worker-threads are disabled and serial arg parameters are set - required for sinon to mock/restore stubs correctly

Notes:

  • Helm chart mountPaths need to be updated from /opt/event-sidecar to /opt/app as follows:
        volumeMounts:
        - mountPath: /opt/app/config
          name: <deployment-name>

BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses /opt/app instead of /opt/event-sidecar which will impact config mounts.

feat(mojaloop/[#2092](https://github.com/mdebarros/simulators/issues/2092)): upgrade nodeJS version for core services - mojaloop/project#2092
- standardised CI scripts
- updated docker-compose files to work correctly
- fixed lint issues
- updated .nvmrc to latest LTS version
- added standard CI scripts/config to package.json: release, snapshot, standard-version, etc
- Updated gitignore to include test/results and IGNORE patterns
- Updated README with standard auto-release information
- Fixed imports
- Fixed lint issues
- Cleaned up Package.json
- Updated dockerfile

Notes:
- Helm chart mountPaths need to be updated from `/opt/event-sidecar` to `/opt/app` as follows:
    ```YAML
        volumeMounts:
        - mountPath: /opt/app/config
          name: <deployment-name>
    ```

BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses `/opt/app` instead of `/opt/simulator` which will impact config mounts.
@mdebarros mdebarros self-assigned this Jul 12, 2022
@mdebarros mdebarros marked this pull request as ready for review July 18, 2022 13:51
@mdebarros
Copy link
Member Author

Last commit test results releases/tag/v12.0.0-snapshot.6 / commits/ac55336cc8866d19bf14e2abe60b8ae0a5efdff5

Testing Toolkit Report
Test Result: PASSED
Test Suite: GP Tests
Environment: moja2.test.mojaloop.live
Total assertions: 2573
Passed assertions: 2573
Failed assertions: 0
Total requests: 587
Total test cases: 129
Passed percentage: 100.00%
Started time: Mon, 18 Jul 2022 14:03:17 GMT
Completed time: Mon, 18 Jul 2022 14:06:08 GMT
Runtime duration: 171104 ms

View Report

Test Result: PASSED
Test Suite: Bulk Tests
Environment: moja2.test.mojaloop.live
Total assertions: 183
Passed assertions: 183
Failed assertions: 0
Total requests: 17
Total test cases: 4
Passed percentage: 100.00%
Started time: Mon, 18 Jul 2022 14:06:20 GMT
Completed time: Mon, 18 Jul 2022 14:06:44 GMT
Runtime duration: 23726 ms

View Report

Testing Toolkit Report
Test Result: PASSED
Test Suite: Thirdparty Tests
Environment: moja2.test.mojaloop.live
Total assertions: 21
Passed assertions: 21
Failed assertions: 0
Total requests: 20
Total test cases: 8
Passed percentage: 100.00%
Started time: Mon, 18 Jul 2022 14:07:23 GMT
Completed time: Mon, 18 Jul 2022 14:07:27 GMT
Runtime duration: 4200 ms

View Report

Screenshot showing Moja2 Event topic after running helm test (i.e. tests executed as per above):

Screenshot 2022-07-18 at 16 09 19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants