-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mojaloop/#2092): upgrade nodeJS version for core services #49
Merged
mdebarros
merged 21 commits into
mojaloop:master
from
mdebarros:feat/#2092-Upgrade-NodeJS-Version-for-core-services
Jul 18, 2022
Merged
feat(mojaloop/#2092): upgrade nodeJS version for core services #49
mdebarros
merged 21 commits into
mojaloop:master
from
mdebarros:feat/#2092-Upgrade-NodeJS-Version-for-core-services
Jul 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(mojaloop/[#2092](https://github.com/mdebarros/simulators/issues/2092)): upgrade nodeJS version for core services - mojaloop/project#2092 - standardised CI scripts - updated docker-compose files to work correctly - fixed lint issues - updated .nvmrc to latest LTS version - added standard CI scripts/config to package.json: release, snapshot, standard-version, etc - Updated gitignore to include test/results and IGNORE patterns - Updated README with standard auto-release information - Fixed imports - Fixed lint issues - Cleaned up Package.json - Updated dockerfile Notes: - Helm chart mountPaths need to be updated from `/opt/event-sidecar` to `/opt/app` as follows: ```YAML volumeMounts: - mountPath: /opt/app/config name: <deployment-name> ``` BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses `/opt/app` instead of `/opt/simulator` which will impact config mounts.
… + minor tweaks to package.json
Last commit test results releases/tag/v12.0.0-snapshot.6 / commits/ac55336cc8866d19bf14e2abe60b8ae0a5efdff5
Screenshot showing Moja2 Event topic after running |
elnyry-sam-k
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092
Notes:
/opt/event-sidecar
to/opt/app
as follows:BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses
/opt/app
instead of/opt/event-sidecar
which will impact config mounts.