feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th validation feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - fixed logger module names for deferred and gross handlers - updated modle.transferSettlement.facade.updateTransferSettlement to correctly capture participantPositionChange entries - added some comments to help clarify whats going on in the modle.transferSettlement.facade.updateTransferSettlement
22 tasks
… into feat/#2880-Simplify-liquidity-cover-check-and-fix-issue-with-validation
mdebarros
changed the title
- updated dependencies - standardised package.json order - removed deprecated faucet and replace with tap-spec, and updated associated npm test scripts - replaced npm-audit-resolve with audit-ci - audit fixes
mdebarros
requested review from
vgenev,
elnyry-sam-k,
lewisdaly,
oderayi and
shashi165
as code owners
elnyry-sam-k
reviewed
Sep 7, 2022
elnyry-sam-k
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880
model.transferSettlement.facade.updateTransferSettlementto correctly capture participantPositionChange entrieschore: maintenace