Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mojaloop/#2928): add contextual logging functionality #39

Merged
merged 10 commits into from
Nov 17, 2022
Merged

feat(mojaloop/#2928): add contextual logging functionality #39

merged 10 commits into from
Nov 17, 2022

Conversation

kleyow
Copy link
Contributor

@kleyow kleyow commented Nov 2, 2022 •
edited
Loading

  • Update format function to retrieve and format an optional context object.

kleyow
kleyow commented Nov 3, 2022
View reviewed changes
src/index.js Show resolved Hide resolved
mdebarros
mdebarros previously approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments to address

README.md Show resolved Hide resolved
src/index.js Show resolved Hide resolved
@mdebarros mdebarros self-requested a review November 16, 2022 07:34
@mdebarros mdebarros dismissed their stale review November 16, 2022 07:35

Comments to be addressed

mdebarros
mdebarros approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kleyow kleyow merged commit 8d29f41 into master Nov 17, 2022
@kleyow kleyow deleted the feat/context branch November 17, 2022 13:13
@kleyow kleyow mentioned this pull request Nov 22, 2022
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebarros mdebarros mdebarros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleyow @mdebarros