Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before signing a challenge on the client side,
navigator.credentials.create
converts the challenge to base64 encoding.In order for this challenge to line up with the
clientDataJSON
field, we should also convert the challenge to base64 encoding before passing into the fido2-lib.I think the way we have been doing it until now is a little incorrect, since we have been base64 encoding the challenge before passing it to the auth service