Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): more credential tests #93

Merged
merged 12 commits into from
Oct 19, 2021

Conversation

lewisdaly
Copy link
Contributor

I'm working on a minisite that makes it easy to generate credentials.

While doing so, I found that the auth-service was having problems with some of these credentials... is it a problem with the auth-service? Or maybe it's a problem elsewhere... Let's find out

@lewisdaly
Copy link
Contributor Author

Ok. I think the auth service should base64 decoded the credential.id before converting to an ArrayBuffer, this seems to be what the fido2-lib likes

@lewisdaly lewisdaly marked this pull request as ready for review October 19, 2021 04:59
@lewisdaly lewisdaly merged commit 6227082 into mojaloop:master Oct 19, 2021
@lewisdaly lewisdaly deleted the feat/more-credential-tests branch October 19, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants