feat(mojaloop/#3139)!: rework config to accept env variables for DB #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleyow
changed the title
kleyow
force-pushed
the
feat/#3139-env-set
branch
from
7ca8711 to
7b0a28f
Compare
kleyow
requested review from
elnyry-sam-k,
lewisdaly,
vijayg10 and
mdebarros
as code owners
kleyow
changed the title
mdebarros
requested changes
Feb 28, 2023
mdebarros
reviewed
Feb 28, 2023
mdebarros
reviewed
Feb 28, 2023
mdebarros
reviewed
Feb 28, 2023
src/shared/config-db.ts
Outdated
| }, | ||
| timezone: { | ||
| doc: 'Database timezone', | ||
| format: '*', |
There was a problem hiding this comment.
Do they have a format for timezone? or perhaps this should be an enum?
There was a problem hiding this comment.
No and probably not. Since knex services connecting to multiple flavors of databases I think the format can be a varied set of strings.
Updated it to be a String
|
@mdebarros addressed comments. |
CI checks are failing. |
mdebarros
reviewed
Feb 28, 2023
src/shared/config-db.ts
Outdated
| format: DbPoolFormat.name, | ||
| default: null | ||
| min: { | ||
| doc: 'Database timezone', |
There was a problem hiding this comment.
Doc discriptions look like copy-pasta?
I think they all need to be updated to match the config pool paramater's description.
Same comment applies to other connection-pool configs.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#3139): rework config to accept env variables for DB - mojaloop/project#3139
'memory'for sqllite for testing which took a string but now it can take an object.