Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: change migration directory and migration flow, prune docker image #18

Merged
merged 12 commits into from
Jun 27, 2022

Conversation

kleyow
Copy link
Contributor

@kleyow kleyow commented Jun 24, 2022

🛑 BREAKING CHANGE

Existing old migration table
If you have a deployment of an old version of als-consent-oracle running you might need to drop your migration table due to previously depending on typescript migration files while now the migrations are dependent on their javascript compiled variants.

Another potential option is to search the migration table and search for any .ts extension and update it to .js
Atm we haven't tested any solutions that don't result dropping the database since at this point in time the als-consent-oracle is not used in production anywhere.

In an effort to lessen confusion when deploying, running migrations and configuring the service the docker image has been pruned to below

dist
│
└───config (Mount your default.json config file here)
└───migrations
└───seeds
└───src
└───package.json
logs
node_modules
package-lock.json
package.json

@kleyow kleyow changed the title fix: fix migration directory path fix!: change migration directory and migration flow, prune docker image Jun 25, 2022
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mdebarros mdebarros merged commit ed522f6 into mojaloop:master Jun 27, 2022
@kleyow kleyow deleted the chore/build branch June 27, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants