From dd18cb225ad4e432e308981e13ce7f7f2f288e00 Mon Sep 17 00:00:00 2001 From: ScriptedAlchemy Date: Mon, 9 Dec 2024 16:31:09 -0800 Subject: [PATCH] chore: address lint warnings --- packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts | 2 +- packages/enhanced/src/lib/sharing/ProvideSharedDependency.ts | 2 +- packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.ts | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts b/packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts index 4d4b8f39f97..f4e9d5588e9 100644 --- a/packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts +++ b/packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts @@ -317,7 +317,6 @@ class ConsumeSharedPlugin { async (resolveData: ResolveData): Promise => { const { context, request, dependencies, contextInfo } = resolveData; // wait for resolving to be complete - //@ts-ignore return promise.then(() => { if ( dependencies[0] instanceof ConsumeSharedFallbackDependency || @@ -345,6 +344,7 @@ class ConsumeSharedPlugin { }); } } + return; }); }, ); diff --git a/packages/enhanced/src/lib/sharing/ProvideSharedDependency.ts b/packages/enhanced/src/lib/sharing/ProvideSharedDependency.ts index d811e82929c..eb61bae23b8 100644 --- a/packages/enhanced/src/lib/sharing/ProvideSharedDependency.ts +++ b/packages/enhanced/src/lib/sharing/ProvideSharedDependency.ts @@ -110,7 +110,7 @@ class ProvideSharedDependency extends Dependency { read(), read(), ); - //@ts-ignore + // @ts-expect-error - webpack serializer pattern requires static property this.shareScope = context.read(); obj.deserialize(context); return obj; diff --git a/packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.ts b/packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.ts index 5b6955f975a..6d4c687f9e5 100644 --- a/packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.ts +++ b/packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.ts @@ -1,4 +1,3 @@ -//@ts-nocheck export default { definitions: { Provides: {