-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade WebdriverIO to v9, drop JWP capabilities #2852
Conversation
🦋 Changeset detectedLatest commit: c8d8352 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fbc632d
to
7203a0e
Compare
7203a0e
to
e755f6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. Two questions and then likely good to go.
|
||
function getPlatform(c: WebDriver.DesiredCapabilities): string | undefined { | ||
return c.platformName || c.platform; | ||
function getPlatform(c: WebdriverIO.Capabilities): string | undefined { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this file get this type value from? If it works, it works, but confused that there is no import. The main question is if we're doing something special somewhere else, or relying on something that I can't see, then is it visible to a more experienced WebdriverIO user in a way that would prevent their consumption of this from causing them issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to use this but got error "Cannot use namespace 'Capabilities' as a type".
import type { Capabilities } from '@wdio/types';
The namespace is defined here, seems like it's done for supporting custom capabilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it run fine in other projects this way. I'm fine with whatever works, it was just surprising to see and would be annoying if this caused some undocumented requirements on consumers.
# Conflicts: # package-lock.json
What I did
webdriverio
to v9 and changed the saucelabs launcher accordinglyNote
Tested locally by running tests for
@web/test-runner-webdriver
package. These don't currently run in CI as they were skipped long ago, in particular due to webdriverio/selenium-standalone#788 - that issue is now fixed but unfortunately the fix landed in a version that dropped Node 18 support.