만든 사람들 페이지 #184
Merged
만든 사람들 페이지 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coko-Front into issue/#181/Part_Name
…coko-Front into issue/#181/Part_Name
…e-team/8term-coko-Front into issue/#177/creators_page
rhehfl
requested review from
bluetree7878,
dmsdnWkd1234,
chamjin,
zzzRYT and
ssi02014
as code owners
Closed
3 tasks
bluetree7878
approved these changes
Feb 26, 2025
| document.removeEventListener('wheel', blockScroll); | ||
| }, | ||
| }); | ||
| const [isPaused, toggleIsPaused] = useToggle(false); |
There was a problem hiding this comment.
여태 useState + 토글 함수를 따로 만들어서 사용했는데 해당 훅을 사용하면 함수를 따로 만들 필요가 없어서 간편하네요. 😲
| if (quizIntroRef.current) { | ||
| scrollToElement(quizIntroRef.current, { behavior: 'smooth' }); | ||
| } | ||
| }; | ||
|
|
||
| return ( | ||
| <S.IntroWrapper> | ||
| <title>코코-자바스크립트 학습 사이트</title> |
There was a problem hiding this comment.
갑자기 좀 고민되는 게 해당 title 태그 모든 곳에서 동일한 타이틀명으로 두는 게 좋을까요?
아니면 약간 다르게 주는 게 좋을까요? (예시: 코코 - 학습, 코코 - 상점)
There was a problem hiding this comment.
페이지마다 다르게 해두는게 좋을 것 같은데 어떤가요?
ssi02014
reviewed
Feb 26, 2025
src/features/intro/constants.ts
Outdated
Comment on lines
389
to
392
| export const MEMBER_DETAILS: Record< | ||
| string, | ||
| { team: string; description: string; sns: { icon: string; url: string }[] } | ||
| > = { |
There was a problem hiding this comment.
상수는 as const 정의해서 사용하는게 어떨까요?
key와 관련된 문제라면 modern-kit objectKeys와 같은 모듈을 사용하면 웬만한 문제는 해결이 가능합니다
There was a problem hiding this comment.
어느정도 형식이 규격화? 된 상수들은 이런식으로 별도 타입을 정의해서 사용했었는데 좋은 습관은 아니였나 보네요 🙄
리뷰 감사합니다!
There was a problem hiding this comment.
@rhehfl 상수와 같이 형식이 정해져있는 값들은 타입이 오히려 더 디테일하게 다뤄지는게 맞다고 생각해요 😄
ssi02014
reviewed
Feb 26, 2025
src/pages/creators/Creators.tsx
Outdated
Comment on lines
16
to
20
| const handleSetMember: (value: string) => void = value => { | ||
| if (!COKO_TEAM_INFO.some(team => team.label === value)) { | ||
| setMember(value); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const handleSetMember: (value: string) => void = value => { | |
| if (!COKO_TEAM_INFO.some(team => team.label === value)) { | |
| setMember(value); | |
| } | |
| }; | |
| const handleSetMember = (value: string) => { | |
| if (!COKO_TEAM_INFO.some(team => team.label === value)) { | |
| setMember(value); | |
| } | |
| }; |
함수 자체 타입 정의는 안해도 될 것 같습니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
#177
📝작업 내용
만든 사람들(모애8기) 를 소개하는 페이지를 추가
반응형
🔍 변경 사항
💬리뷰 요구사항 (선택사항)