Fluid.Pipes.BaseClasses.WallFriction.PartialWallFriction.pressureLoss_m_flow not backward compatible

[modelica-trac-importer]

Reported by mwetter on 6 Feb 2015 02:28 UTC
In
v3.2.1+build.3-rc1/Modelica/Fluid/Pipes.mo
the function
Modelica.Fluid.Pipes.BaseClasses.WallFriction.PartialWallFriction.pressureLoss_m_flow
contains the input argument crossArea with no default value.
This is not present in 3.2.1 build 2.

This addition is not backward compatible.

Here is the diff:

diff v3.2.1+build.2.release/Modelica/Fluid/Pipes.mo v3.2.1+build.3-rc1/Modelica/Fluid/Pipes.mo | grep -C 1 "input SI.Area crossArea"
1875a1870
>           input SI.Area crossArea "Inner cross section area";

1901a1897
>           input SI.Area crossArea "Inner cross section area";

1929a1926
>           input SI.Area crossArea "Inner cross section area";

1956a1954
>           input SI.Area crossArea "Inner cross section area";

2050c2048
\--
2756a2767
>             input SI.Area crossArea "Inner cross section area";

2808a2820
\--
2846a2859
>             input SI.Area crossArea "Inner cross section area";

2898a2912
\--
3235a3248
>           input SI.Area crossArea "Inner cross section area";

3331c3344
\--
3349a3363
>           input SI.Area crossArea "Inner cross section area";

3422c3436

---

Migrated-From: https://trac.modelica.org/Modelica/ticket/1656

[modelica-trac-importer]

Comment by rfranke on 9 Feb 2015 04:51 UTC
This was introduced to fix #1601 -- the pressure loss models were only correct for circular pipes, even though non-circular pipes can be configured. I'll investigate if the backwards compatibility can be improved.

[modelica-trac-importer]

Comment by rfranke on 9 Feb 2015 07:34 UTC
It is generally justified to break backwards compatibility if an error is corrected. Nevertheless we should attempt to minimize newly introduced problems of course.

fad2b11 adds default values to the new crossArea inputs of
Modelica.Fluid.Pipes.BaseClasses.WallFriction.PartialWallFriction.pressureLoss_m_flow and
Modelica.Fluid.Pipes.BaseClasses.WallFriction.PartialWallFriction.massFlowRate_dp

These are the two basic functions without staticHead that could be fixed easily. They include the function pressureLoss_m_flow that you are referring to.

Can you please check if this fills your need?

[modelica-trac-importer]

Comment by mwetter on 10 Feb 2015 01:51 UTC
This fixes the problem.
Thanks!

[modelica-trac-importer]

Modified by beutlich on 10 Feb 2015 11:02 UTC

[modelica-trac-importer]

Comment by rfranke on 10 Feb 2015 17:46 UTC
33953f5 adds default values to the new crossArea inputs of functions with static head as well