Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid weaker comparison for targets in run_cargo #3111

Open
adpaco-aws opened this issue Mar 26, 2024 · 0 comments
Open

Avoid weaker comparison for targets in run_cargo #3111

adpaco-aws opened this issue Mar 26, 2024 · 0 comments
Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected.

Comments

@adpaco-aws
Copy link
Contributor

Proposed change: We should revisit the same_target check in run_cargo after a while to see if it's not needed anymore or it can be restricted to certain cases. This newer check was introduced in #3102 during a toolchain upgrade.

Motivation: The previous comparison was rustc_artifact == *target, but it started to fail in some cases after the cargo change in rust-lang/cargo#12783.
@adpaco-aws adpaco-aws added the [C] Internal Tracks some internal work. I.e.: Users should not be affected. label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adpaco-aws