Recipes with foreign_key and one_to_one=True breaks

[walison17]

Recipes that uses reverse relationship foreign_key and one_to_one=True break when call make

profile_recipe = Recipe(Profile, phone='5581999999999')
user_recipe = Recipe(User, profile=foreign_key(profile_recipe, one_to_one=True))

user_recipe.make(_quantity=2)

What you expected.

2 users created and 2 profiles created attached to each other.

What happened instead.

ValueError: Cannot assign "<itertools.cycle object at 0x7f4f0f927080>": "User.profile" must be a "Profile" instance.

Versions

Python: 3.9.3
Django: 3.1.8
Model Bakery: 1.3.2

[berinhard]

Hi @walison17 thanks for opening this issue. Probably the fix for this should also fix #28 because, even though they differ a little bit on their contexts.

But, actually, I fell that the modeling you've used to describe your problem is not correct. Because, every time you baker.make_recipe("yourapp.profile") you'll already populate the FK to the user. So, in your test, you can do things such as:

user_with_profile = baker.make_recipe("yourapp.profile").user

Also, by using the recipes the way you've defined, you'll always end up with more users than you're probably expecting. This is because, to make a Profile instance, baker is obligated to create a user because of the FK. So, if you call the user_with_profile recipe as you're suggesting, baker will:

• Create 2 new Profile objects and 2 new User objects one for each;
• Create 2 new User objects and associate them with the existing profiles;
• The 2 Users previously created will stay in the DB but as "without profiles users";

This is one of the problems of using Recipes combined with related name to create objects. I'm not so sure if it's possible to fix this though, since the usage of foreign_key method was designed to respect the foreign key direction and not be used with related names.

[berinhard]

I don't know, maybe we're missing some type of dependency inversion here to make the tests easier and more semantics. I don't know, something like:

# baker_recipes.py

profile = Recipe("yourapp.profile")

user_with_profile = from_recipe_fk('profile', 'user', username='foo')

This method would output a special type of recipe that depends on a previous one to work. So it'll:

• Create the Profile recipe and, by doing so, create the User instance;
• It should use its kwargs to create the User instance (as the username one in the example above);
• Instead of returning the Profile, it should return the profile.user object;

@amureki or @anapaulagomes what do you think about this?

[berinhard]

I'm closing this issue since the same problem was already documented in #97.

[egorgam]

actual at version 1.15.0