Error in expected_error.py

[panushri25]

Hello,

I noticed a bug in your expected_error.py. In line 70, the loss variable which is supposed to be log/binary is being replaced with a local variable. As a result after the first iteration the if statement does not execute and the loss remains constant. Just change the variable to nloss or something else and it should work.

Thank you,

[panushri25]

Also i think you need to take a argmin instead of argmax. And when evaluating loss using refitted_proba, you should exclude the point already being queried to calculate the future loss.

[cosmic-cortex]

Thanks! These were indeed wrong, I have fixed them. The changes were merged to the master branch!

[panushri25]

your refitted_proba should not include x_idx for future loss right ? otherwise your training point is in test too.

[cosmic-cortex]

Sorry, I have also fixed that but forgot to push the commit :) Now it is pushed and merged to the main branch.