-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser: improve 'bdd' import for bundlers #4769
Conversation
Thank you, @juergba and @PaperStrike ! 🎉 |
Actually I'm still confused how it works... As in #4746, I'm using Since |
Yes, but I'm unsure about the implications, yet. |
Description
History: #4746
Above PR proved to be too restrictive as it's no longer possible to do ES6 style
import { describe, it } from 'mocha'
while using bundlers.Description of the Change
browser-entry.js: push all
bdd
functions fromglobal
tomocha
.We have conflicts between
global.setup
(tdd
version ofbeforeEach
hook) andmocha.setup
(browser setup), and therefore we don't copy thetdd
functions tomocha
. Thetdd
interface has never/won't be available for ES6 style import.At the time of copying the
bdd
functions are undefined, nevertheless bundlers seem to rely on those lines. The exact logic remained unclear to me.Applicable issues
closes #4763