Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build to GH actions run #4601

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Conversation

christian-bromann
Copy link
Contributor

@christian-bromann christian-bromann commented Mar 9, 2021

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

This patch contains modifications to the karma.conf.js to include build ids to the tests. This will fix the invalid badge on the Readme which now shows unknown because no new builds have been created for a while.

Alternate Designs

None, build id is required to display correct badge information

Why should this be in core?

Because the readme lives in this repo.

Benefits

Showing up to date build status promotes MochaJS being a stable testing framework.

Possible Drawbacks

None.

Applicable issues

It is a documentation update.

@christian-bromann
Copy link
Contributor Author

christian-bromann commented Mar 9, 2021

Also, in order to not show failing builds from PRs I recommend to create a user for main branch builds and use that one for everything merged into the main branch. Sauce Labs infrastructure unfortunately doesn't not yet know anything about your git environment.

@coveralls
Copy link

coveralls commented Mar 9, 2021

Coverage Status

Coverage remained the same at 94.155% when pulling f4a0d41 on christian-bromann:cb-sauce-build into c6f874f on mochajs:master.

@juergba juergba added area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Mar 10, 2021
@juergba juergba requested review from juergba and outsideris March 10, 2021 05:54
Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christian-bromann thanks for this PR.
I have noticed the unknown label a few days ago, but didn't really know the cause.

@juergba
Copy link
Contributor

juergba commented Mar 11, 2021

@christian-bromann I pushed your branch to our repo in order to check our browser tests. They passed, but the ESLint tests failed.
I have fixed thoses linting errors.

@outsideris For PR's from forked repos the ESLint tests are not reliable since they pass inspite of linting errors. There is a job Tests / ESLint Results which is missing for forked repos. I suppose the reason is: pull-request events from forked repos don't have write access to our repo. Therefore the linting results (which is an artifact) are silently lost.

@juergba
Copy link
Contributor

juergba commented Mar 11, 2021

I'm going to merge this PR, I'm unsure wether it's going to work though.

Edit: the label still shows unknown, maybe the change will take some time.
Our coverall test has failed pretending that 94.155 < 94.155 (-5.8%).

@juergba juergba merged commit 21652d9 into mochajs:master Mar 11, 2021
@juergba juergba added this to the next milestone Mar 11, 2021
@christian-bromann
Copy link
Contributor Author

@juergba yeah, it seems that the image in the readme is cached by GitHub, adding a ?foo at the end makes it load fresh and it works now:

Mocha Browser Support h/t SauceLabs

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants