-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build to GH actions run #4601
Conversation
Also, in order to not show failing builds from PRs I recommend to create a user for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christian-bromann thanks for this PR.
I have noticed the unknown
label a few days ago, but didn't really know the cause.
@christian-bromann I pushed your branch to our repo in order to check our browser tests. They passed, but the ESLint tests failed. @outsideris For PR's from forked repos the ESLint tests are not reliable since they pass inspite of linting errors. There is a job |
I'm going to merge this PR, I'm unsure wether it's going to work though. Edit: the label still shows |
@juergba yeah, it seems that the image in the readme is cached by GitHub, adding a |
Requirements
Description of the Change
This patch contains modifications to the
karma.conf.js
to include build ids to the tests. This will fix the invalid badge on the Readme which now showsunknown
because no new builds have been created for a while.Alternate Designs
None, build id is required to display correct badge information
Why should this be in core?
Because the readme lives in this repo.
Benefits
Showing up to date build status promotes MochaJS being a stable testing framework.
Possible Drawbacks
None.
Applicable issues
It is a documentation update.