Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-environment-flags to 1.0.6 #4118

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

kylef
Copy link
Contributor

@kylef kylef commented Dec 4, 2019

Description of the Change

node-environment-flags 1.0.5 and lower do not contain a LICENSE file which can make compliance difficult. This pull request updates the patch release of node-environment-flags to incorporate boneskull/node-environment-flags#5.

Alternate Designs

Removing the dependency on node-environment-flags.

Why should this be in core?

To ensure the entire dependency chain of Mocha has dependencies contains valid copyright and licenses.

Possible Drawbacks

I don't think there are any.

Applicable issues

  • Mocha follows semantic versioning: http://semver.org

  • Is this a breaking change (major release)?

  • Is it an enhancement (minor release)?

  • Is it a bug fix, or does it not impact production code (patch release)?

It's a bug fix, fixing licensing.

@jsf-clabot
Copy link

jsf-clabot commented Dec 4, 2019

CLA assistant check
All committers have signed the CLA.

package.json Outdated Show resolved Hide resolved
node-environment-flags 1.0.5 and lower do not contain a LICENSE file
which can make compliance difficult.
@kylef kylef force-pushed the kylef/node-environment-flags branch from 9bb70a6 to 5faba2c Compare December 15, 2019 19:56
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 92.972% when pulling 5faba2c on kylef-archive:kylef/node-environment-flags into 25363e6 on mochajs:master.

Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylef thank you

@juergba juergba added type: chore generally involving deps, tooling, configuration, etc. area: node.js command-line-or-Node.js-specific semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Dec 16, 2019
@juergba juergba added this to the v7.0.0 milestone Dec 16, 2019
@juergba juergba merged commit d9f5079 into mochajs:master Dec 16, 2019
@kylef kylef deleted the kylef/node-environment-flags branch December 16, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: node.js command-line-or-Node.js-specific semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants