Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in IE8 after release v2.4.1 #2078

Closed
ConstantineYurevich opened this issue Jan 27, 2016 · 13 comments
Closed

Doesn't work in IE8 after release v2.4.1 #2078

ConstantineYurevich opened this issue Jan 27, 2016 · 13 comments

Comments

@ConstantineYurevich
Copy link

All my tests started to fail after new release in IE8 with the following error:

Object doesn't support this property or method
  at /home/travis/build/driveback/digital-data-manager/node_modules/mocha/mocha.js:11671
@gyandeeps
Copy link
Contributor

Thats because at ~3 spots Object.keys and ~2 spots forEach was used directly rather than checking if the function is present or not.

@boneskull
Copy link
Contributor

Ugh.

@boneskull
Copy link
Contributor

Just load es5-shim until we fix it (very soon)

@gyandeeps
Copy link
Contributor

@yaniswang do you have it for object.keys and [].forEach?

@boneskull
Copy link
Contributor

alright, testing this fix atm.

@gyandeeps
Copy link
Contributor

@boneskull why not use the polyfill for 2 methods (keys and forEach) so that it easy to remove later on when we end IE8 support?

@boneskull
Copy link
Contributor

@gyandeeps rather not add another dependency or monkey with other stuff right now.

@boneskull
Copy link
Contributor

@yurevichcv can you run your tests with this mocha.js file and tell me if you have better results in IE8?

@boneskull
Copy link
Contributor

@gyandeeps anyway, mocha contains a bunch of hand-rolled shims which need replacing. it's a somewhat bigger job than you'd expect

@gyandeeps
Copy link
Contributor

I see. thanks

@boneskull
Copy link
Contributor

downloading an IE8 vm to try it myself

@danielstjules
Copy link
Contributor

@boneskull Your changes work:

Before

screen shot 2016-01-27 at 8 10 36 am

After

screen shot 2016-01-27 at 8 11 57 am

@boneskull
Copy link
Contributor

v2.4.3 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants