Upgrade jsdiff to v1.4.0 #1699
Merged
Upgrade jsdiff to v1.4.0 #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of jsdiff reverses the + and - diff line order to the standard order used by git, diff, etc. Tests updated accordingly.
|
LGTM. Thanks @nylen! |
dasilvacontin
added a commit
that referenced
this pull request
May 13, 2015
Upgrade jsdiff to v1.4.0
|
👏 :) |
|
Thanks!! Can we get a new version? |
|
There are ~5 fixes waiting in master. A patch release would be appropriate. |
|
ok gonna make a release right now |
|
💥 done, thanks all! |
|
kudos @travisjeffery! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsdiffv1.4.0 contains a fix for kpdecker/jsdiff#14. Upgrading will display multi-line diffs in the same standard order asdiff,git, etc:The current order is unintuitive which makes it harder to read at a glance:
Supersedes #1647. cc @danielstjules @boneskull