From bec18a97aaa16e7f910c784298950a8449d6a87a Mon Sep 17 00:00:00 2001 From: Dayzen Date: Sat, 14 Dec 2019 17:43:08 +0900 Subject: [PATCH] Remove util.inspect.custom API --- lib/reporters/base.js | 5 +---- test/reporters/base.spec.js | 20 ++------------------ 2 files changed, 3 insertions(+), 22 deletions(-) diff --git a/lib/reporters/base.js b/lib/reporters/base.js index 75c1af35e5..8395c7dffd 100644 --- a/lib/reporters/base.js +++ b/lib/reporters/base.js @@ -8,7 +8,6 @@ var diff = require('diff'); var milliseconds = require('ms'); -var util = require('util'); var utils = require('../utils'); var supportsColor = require('supports-color'); var symbols = require('log-symbols'); @@ -237,9 +236,7 @@ exports.list = function(failures) { err = test.err; } var message; - if (typeof err[util.inspect.custom] === 'function') { - message = util.inspect(err) + ''; - } else if (typeof err.inspect === 'function') { + if (typeof err.inspect === 'function') { message = err.inspect() + ''; } else if (err.message && typeof err.message.toString === 'function') { message = err.message + ''; diff --git a/test/reporters/base.spec.js b/test/reporters/base.spec.js index aec4d2e55f..a920730587 100644 --- a/test/reporters/base.spec.js +++ b/test/reporters/base.spec.js @@ -2,7 +2,6 @@ var assert = require('assert'); var chai = require('chai'); -var util = require('util'); var sinon = require('sinon'); var helpers = require('./helpers'); var reporters = require('../../').reporters; @@ -367,22 +366,7 @@ describe('Base reporter', function() { expect(errOut, 'to be', '1) test title:\n Error\n foo\n bar'); }); - it("should use 'util.inspect.custom' if err is including util.inspect.custom parameter", function() { - var err = new Error('test'); - err.showDiff = false; - err[util.inspect.custom] = function() { - return 'Custom Formatted Error'; - }; - - var test = makeTest(err); - - list([test]); - - var errOut = stdout.join('\n').trim(); - expect(errOut, 'to contain', 'Custom Formatted Error'); - }); - - it("should use 'inspect' if 'util.inspect.custom' is not set", function() { + it("should use 'inspect' if err include 'inspect' parameter", function() { var err = new Error('test'); err.showDiff = false; err.inspect = function() { @@ -398,7 +382,7 @@ describe('Base reporter', function() { expect(errOut, 'to contain', 'Inspect Error'); }); - it("should set an empty message if 'util.inspect.custom' and 'inspect' and 'message' is not set", function() { + it("should set an empty message if neither 'inspect' nor 'message' is set", function() { var err = { showDiff: false };