-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation error due to "Unbound module Ethernet__Ethernet_wire" #630
Comments
similar here, trying to build for Ubuntu: xxx@DESKTOP-ES15K2K:~/git/vpnkit$ make |
Looks like this is due to mirage/ethernet@61dfc14 |
I have managed to pin the dependencies to a state that builds successfully without changing the codebase. Here is the diff I have so far diff --git a/vpnkit.opam b/vpnkit.opam
index 1c5b6ef2..b9384b0b 100644
--- a/vpnkit.opam
+++ b/vpnkit.opam
@@ -1,3 +1,4 @@
+version: "0.5.0"
opam-version: "2.0"
maintainer: "David Scott <dave.scott@docker.com>"
authors: [
@@ -23,12 +24,12 @@ build: [
depends: [
"ocaml" {>="4.08.0"}
- "dune"
+ "dune" {< "3.1.0"}
"alcotest" {with-test}
"ounit" {with-test}
"tar" {>= "1.0.1"}
"ipaddr" {>= "5.0.1"}
- "lwt" {>= "5.4.0"}
+ "lwt" {>= "5.4.0" & < "5.6.0"}
"luv"
"luv_unix"
"tcpip" {>= "7.0.0"}
@@ -36,15 +37,15 @@ depends: [
"cstruct" {>= "6.0.0"}
"pcap-format" {>= "0.4.0"}
"cmdliner" {< "1.1.0"}
- "charrua" {>= "1.3.0"}
- "charrua-client"
- "charrua-server"
+ "charrua" {>= "1.3.0" }
+ "charrua-client" {>= "1.3.0" }
+ "charrua-server"{>= "1.3.0" }
"hvsock" {>= "2.0.0"}
"fd-send-recv" {>= "2.0.0"}
"logs"
"fmt"
"astring"
- "ethernet" {>= "3.0.0"}
+ "ethernet" {>= "3.0.0" & < "3.1.0"}
"arp" {>= "3.0.0"}
"mirage-entropy" {>= "0.5.0"}
"mirage-kv" {>= "4.0.0"}
@@ -54,7 +55,7 @@ depends: [
"mirage-stack"
"cohttp-lwt" {>= "0.99.0"}
"protocol-9p" {>= "2.0.0"}
- "mirage-vnetif" {>= "0.5.0"}
+ "mirage-vnetif" {>= "0.5.0" & < "0.6.0"}
"io-page-unix"
"uuidm"
"ezjsonm" {>= "0.4.0"}
@@ -66,6 +67,7 @@ depends: [
"mirage-random-stdlib"
"re" {>= "1.9.0"}
"ppx_inline_test"
+ "result"
]
synopsis: "VPN-friendly networking devices for HyperKit"
description: """ |
@LaurentGoderre pinning the dependencies sounds like a good initial step! Would you have time to create a PR? We could update the code to use the latest versions later (since that will be more invasive) |
@djs55 that is what I am working on yes but the e2e tests are failing so I am trying to resolve it |
@djs55 I believe we can close this now |
I am trying to build the repository from the master branch (as there are no binary distributions) on a Mac,
but there are references to data structures that are no more present in "ethernet" {>= "3.0.0"}:
vpnkit/src/hostnet/hostnet_dns.ml
Line 256 in ee2e5c0
I also had to comment out these lines:
https://github.com/moby/vpnkit/blob/master/dune#L14-L17
The text was updated successfully, but these errors were encountered: