Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mountinfo.Mounted: incorrect results for some corner cases #88

Closed
kolyshkin opened this issue Oct 25, 2021 · 5 comments · Fixed by #90
Closed

mountinfo.Mounted: incorrect results for some corner cases #88

kolyshkin opened this issue Oct 25, 2021 · 5 comments · Fixed by #90

Comments

@kolyshkin
Copy link
Collaborator

As reported by @mkimuram here: kubernetes/kubernetes#105833 (comment)

Obviously, issues a and b can be fixed by using filepath.EvalSymlinks (and in view of that part of #86 might need to be reverted).

Not sure what to do with issue c for now...

@kolyshkin kolyshkin changed the title mountinfo bugz mountinfo.Mounted: incorrect results for some corner cases Oct 25, 2021
@mkimuram
Copy link

Not sure what to do with issue c for now...

Actually, issue c should be also fixed if we are sure that the path is no longer a symlink (In that case, /foo, instead of /baz/bar/mounted, is passed as an argument).

@kolyshkin
Copy link
Collaborator Author

@mkimuram right :) somehow I missed it yesterday.

I am adding more test cases, as well as fixes.

@thaJeztah
Copy link
Member

I was looking if we should do a new release of the modules in this repository; let me wait until this one is addressed 👍 (from your comment, I gather you're working on this, @kolyshkin ?)

@kolyshkin
Copy link
Collaborator Author

@thaJeztah yes, I want to release mountinfo 0.5.0 once all this is merged. PTAL #89, #90.

@kolyshkin

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants