Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.12 backport] testutil: move CheckContainerdVersion to a separate package #4029

Merged
merged 1 commit into from
Jul 17, 2023
Merged

[0.12 backport] testutil: move CheckContainerdVersion to a separate package #4029

merged 1 commit into from
Jul 17, 2023

Conversation

thaJeztah
Copy link
Member

This function was introduced in 601dd5b, but brings in "containerd" as a dependency for testutil/integration, which results in many (indirect) dependencies.

(cherry picked from commit 619a20d)

@thaJeztah
testutil: move CheckContainerdVersion to a separate package
ad68d6c 
This function was introduced in 601dd5b,
but brings in "containerd" as a dependency for testutil/integration, which
results in many (indirect) dependencies.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 619a20d)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the v0.12.1 milestone Jul 17, 2023
@thaJeztah thaJeztah mentioned this pull request Jul 17, 2023
Merged
4 tasks
@jedevc jedevc merged commit faa0cc7 into moby:v0.12 Jul 17, 2023
@thaJeztah thaJeztah deleted the 0.12_backport_move_testutil branch July 17, 2023 13:02
@thaJeztah thaJeztah mentioned this pull request Jul 18, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedevc jedevc jedevc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@thaJeztah @jedevc