Allow signals to be sent to gateway exec containers #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Feb 1, 2022
| func (ctrProc *containerProcess) Signal(_ context.Context, sig syscall.Signal) error { | ||
| name := sigToName[sig] | ||
| if name == "" { | ||
| return errors.Errorf("Unknown signal %v", sig) |
executor/runcexecutor/executor.go
Outdated
| // WaitForStart will record the pid reported by Runc via the channel. | ||
| // We wait for up to 10s for the runc process to start. If the started | ||
| // callback is non-nil it will be called after receiving the pid. | ||
| func (p *startingProcess) WaitForStart(ctx context.Context, startedCh chan int, started func()) error { |
There was a problem hiding this comment.
These definitions could use a channel direction constraint
executor/runcexecutor/executor.go
Outdated
| // startingProcess is to track the os process so we can send signals to it. | ||
| type startingProcess struct { | ||
| Process *os.Process | ||
| found chan struct{} |
There was a problem hiding this comment.
Maybe ready better name in here
Signed-off-by: Cory Bennett <cbennett@netflix.com>
coryb
force-pushed
the
gateway-exec-signal
branch
from
21f6dc5
to
559d079
Compare
|
Fixed the comments, should be good now. |
tonistiigi
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2566