solver: fix exporters unsafely sharing records #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
|
@griffous Added a second commit based on your trace in #2041 (comment) |
|
Looks like the second commit is breaking a bunch of things. Need to look again. |
Thanks for the update. Standing by... :) |
tonistiigi
force-pushed
the
exporter-sync-fix
branch
from
ed34a3c
to
4cec7a0
Compare
|
@maxlaverse Any news? |
AkihiroSuda
approved these changes
Oct 21, 2021
|
Sorry @tonistiigi, I had a tab open to check that thoroughly but didn't come to it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #2296
@maxlaverse
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com