Move resolver config to a dedicated package #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
resolver-config
branch
from
520e0fe
to
8ed4f6a
Compare
tonistiigi
reviewed
Sep 27, 2021
cmd/buildkitd/config/config.go
Outdated
| @@ -21,7 +21,7 @@ type Config struct { | |||
| Containerd ContainerdConfig `toml:"containerd"` | |||
| } `toml:"worker"` | |||
|
|
|||
| Registries map[string]resolver.RegistryConfig `toml:"registry"` | |||
| Registries map[string]rconfig.RegistryConfig `toml:"registry"` | |||
There was a problem hiding this comment.
nit: can we call this resolverconfig. I think the extra verbosity is justified here
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
resolver-config
branch
from
8ed4f6a
to
73625be
Compare
tonistiigi
approved these changes
Sep 27, 2021
This was referenced Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #2361
Move resolver config to a dedicated package to avoid importing resolver dependencies while using
cmd/buildkitd/configpackage.Signed-off-by: CrazyMax crazy-max@users.noreply.github.com