bklog: only log tracing ids when span exporter not nil #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Sep 8, 2021
morlay
force-pushed
the
log-fix
branch
2 times, most recently
from
d990079
to
feb9d38
Compare
|
@tonistiigi. we have to added a toggle to enable log with tracing ids. TracingProvider is a side process, we couldn't know is it ready from ctx. |
tonistiigi
reviewed
Sep 8, 2021
tonistiigi
reviewed
Sep 8, 2021
util/tracing/detect/detect.go
Outdated
| @@ -82,6 +83,10 @@ func detect() error { | |||
| if exp == nil { | |||
| return nil | |||
| } | |||
|
|
|||
| // enable log with traceID when valid exporter | |||
| bklog.EnableLogWithTraceID() | |||
There was a problem hiding this comment.
Little bit weird still that this isn't called in main. But I guess it is ok as detect itself should only be called in main.
There was a problem hiding this comment.
in main, we still couldn't know the Exporter is ready or not.
so i have to enable log with trace id when setup exporter.
Signed-off-by: Morlay <morlay.null@gmail.com>
tonistiigi
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enhance #2235