Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing providers for blobs w/ same chainid. #2231

Merged
merged 1 commit into from
Jul 7, 2021

Commits on Jul 7, 2021

  1. Ignore missing providers for blobs w/ same chainid.

    GetByBlob checks to see if there are any other blobs with the same
    (uncompressed) ChainID and, if so, reuses their unpacked snapshot if it
    exists.
    
    The problem is if this code finds a match, it was trying to get the
    matching record, but couldn't do so when the match is lazy because the
    caller doesn't necessarily have descriptor handlers setup for it.
    
    This commit changes the behavior to just ignore any match with the same
    ChainID that's also lazy as they just aren't usable for the
    snapshot-reuse optimization.
    
    Signed-off-by: Erik Sipsma <erik@sipsma.dev>
    sipsma committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    026d6d6 View commit details
    Browse the repository at this point in the history