Add "ALL_PROXY" to list of default args / proxy env-vars #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to https://github.com/linuxkit/linuxkit/blob/a82fff637781877fc0d88c0f6e514fcd24699c46/docs/packages.md#proxies > (..) the first four of these are the standard built-in build-arg options > available for `docker build` > (..) The last, `all_proxy`, is a standard var used for socks proxying. Since > it is not built into `docker build`, if you want to use it, you will need to > add the following line to the dockerfile: > > ARG all_proxy Given the we support all other commonly known proxy env-vars by default, it makes sense to add this one as well. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
@tonistiigi ptal /cc @deitch |
|
PR for classic builder is moby/moby#42318 |
tonistiigi
approved these changes
Apr 26, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/linuxkit/linuxkit/blob/a82fff637781877fc0d88c0f6e514fcd24699c46/docs/packages.md#proxies
Given the we support all other commonly known proxy env-vars by default, it makes
sense to add this one as well.