update to new cross toolchain #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
AkihiroSuda
reviewed
Mar 24, 2021
| FROM gostable AS go-linux | ||
| FROM golatest AS go-darwin | ||
| FROM golatest AS go-windows-amd64 | ||
| FROM golatest AS go-windows-386 |
There was a problem hiding this comment.
Do we want to support windows 386?
There was a problem hiding this comment.
I only left amd64&arm64 in the CI. These are just to cover all possible options. Once we don't need to switch between go versions this can be all removed.
AkihiroSuda
reviewed
Mar 24, 2021
| # xx is a helper for cross-compilation | ||
| FROM --platform=$BUILDPLATFORM tonistiigi/xx:golang@sha256:810dc54d5144f133a218e88e319184bf8b9ce01d37d46ddb37573e90decd9eef AS xx | ||
|
|
||
| FROM --platform=$BUILDPLATFORM golang:1.13-alpine AS gostable |
There was a problem hiding this comment.
(Can be another PR, but we seriously need to move away from Go 1.13)
There was a problem hiding this comment.
@tiborvass has a spreadsheet with all the possible EINTR for syscalls handlers for go1.13+ that needs to be confirmed to not have possible unfixed cases. @tiborvass please share with @AkihiroSuda
But yes, unrelated to this PR.
AkihiroSuda
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AkihiroSuda @crazy-max