-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fd:// for socket activation #1924
Conversation
You need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have documented this in README?
eada72d
to
93e6661
Compare
Sure. I didn't get any feedback on what you wanted to do with the systemd units, in general ? Just stick them in some "contrib/init" or something, or where should such files be located ? But can write some general text for the README.md, like the issue text (or like the tcp://) |
Maybe examples/systemd |
cross is failing
|
systemd on windows ? probably should just skip it there (didn't know you were building buildkitd for Windows) |
I think the test failure is unrelated to this ?
Probably more related to 2f4c15d |
LGTM but please squash commits, it will also restart CI |
Used go-systemd code from moby/moby daemon Only added `buildkitd --addr fd://` for now. Don't do systemd fds for windows buildkitd Add buildkit systemd units README/examples Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Squashed and rebased, as requested. Have you considered adding an idle timeout to buildkitd ? So that it will shut down the service automatically, when done. |
Not against it if we can guarantee that there is no race between daemon shutting down and a new request coming in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging
Used go-systemd code from moby/moby daemon
Only added
buildkitd --addr fd://
for now.Closes #1923