Bump stargz-snapshotter and partial registry logic integration #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current stargz snapshotter pkg doesn't contain registry configuration and the client of that pkg needs to pass it to that pkg. So this commit includes changes of propagating buildkitd's registry configuration to stargz snapshotter. But this is a partial integration of registry logic between buildkitd and stargz snapshotter because buildkitd's session-based authentication logic is still not applied to stargz snapshotter. This means private images that require `~/.docker/config.json` creds can't be lazily pulled yet. Signed-off-by: ktock <ktokunaga.mail@gmail.com>
tonistiigi
approved these changes
Oct 29, 2020
AkihiroSuda
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following-up: #1666 (comment)
#1733 is WIP but this PR is mainly focusing on bumping up the snapshotter pkg and applying bug fixes.
Full diff: containerd/stargz-snapshotter@2ee75e9...3a04e4c
This removes the dependency on
github.com/google/go-containerregistry.Current stargz snapshotter pkg doesn't contain registry configuration and the client of that pkg needs to pass it to that pkg. So this commit includes changes of propagating buildkitd's registry configuration (
docker.RegistryHosts) to stargz snapshotter.But this is a partial integration of registry logic between buildkitd and stargz snapshotter because buildkitd's session-based authentication logic (
(util/resolver).dockerAuthorizer) is still not applied to stargz snapshotter. This means private images that require~/.docker/config.jsoncreds can't be lazily pulled yet. Further discussion towards the session-based authentication integration is in progress at #1733 .