Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move error to separate struct in history API #5088

Closed
tonistiigi opened this issue Jun 25, 2024 · 0 comments · Fixed by #5093
Closed

Move error to separate struct in history API #5088

tonistiigi opened this issue Jun 25, 2024 · 0 comments · Fixed by #5093
Assignees
Milestone

Comments

@tonistiigi
Copy link
Member

The history API record contains a nice typed error atm https://github.com/moby/buildkit/blob/v0.14.1/api/services/control/control.proto#L201 retaining information like the stacktraces, source/vertex mapping etc. The problem is that for some errors this structure can grow quite large, eg. source mapping contains the full Dockerfile source so if (in an extreme case) you have 1MB Dockerfile, this error will also be bigger than 1MB . API requests like listing history will need to transfer all these structures and encode/decode them.

Instead, the current error field should become only a short error with the main message and optionally some additional limited information. The full error should still be kept but should be moved to a separate blob in the contentstore as it is done with logs, traces, provenance attestations etc. If client needs a full error they can pull it with a separate request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants