Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] Emit warning if ADD --chown flag is used with archive file #3700

Open
simnalamburt opened this issue Apr 27, 2018 · 2 comments
Open

Comments

@simnalamburt
Copy link

simnalamburt commented Apr 27, 2018

I noticed a counterintuitive behavior of Moby which is ignoring ADD --chown flag when it is used in conjunction with a compressed file. Moby project had several duplicate issues because of this. It would be better if Moby prohibits such use or displays a warning. What do you think?

I also could not find out where this behavior is documented in the official docs. If this behavior is not documented, it might be better to document it explicitly too.

References
@dmhursh
Copy link

dmhursh commented Aug 30, 2018

I would like this to at least be a warning. I would prefer it were an error since the results will not match what I believe is the only obviously expect outcome.

Better yet would be to have

ADD --chown user:group tarfile.tar.gz /target/directory

behave like

sudo -u user -g group tar --no-same-owner -C /target/directory xzf tarfile.tar.gz

@thaJeztah
Copy link
Member

Let me transfer this ticket to the BuildKit repo, as that's where development is now happening for the builder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants